Skip to content

PSP-10194 : Property information without PIN/PID #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 4, 2025
Merged

PSP-10194 : Property information without PIN/PID #4881

merged 11 commits into from
Jul 4, 2025

Conversation

eddherrera
Copy link
Collaborator

image

image

@eddherrera eddherrera self-assigned this Jul 4, 2025
@eddherrera eddherrera added enhancement New feature or request 5.11 labels Jul 4, 2025
@eddherrera
Copy link
Collaborator Author

Pending unit tests

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4881

@asanchezr
Copy link
Collaborator

@eddherrera - the frontend code is not compiling. Please fix.

Error: src/features/mapSideBar/lease/LeaseView.test.tsx(75,36): error TS2345: Argument of type '{ error: any; response: any; execute: Mock<any, any>; loading: boolean; status: number; }' is not assignable to parameter of type '{ ltsaRequestWrapper: IResponseWrapper<(pid: string) => Promise<AxiosResponse<LtsaOrders, any>>>; getStrataPlanCommonProperty: IResponseWrapper<...>; }'.
Type '{ error: any; response: any; execute: Mock<any, any>; loading: boolean; status: number; }' is missing the following properties from type '{ ltsaRequestWrapper: IResponseWrapper<(pid: string) => Promise<AxiosResponse<LtsaOrders, any>>>; getStrataPlanCommonProperty: IResponseWrapper<...>; }': ltsaRequestWrapper, getStrataPlanCommonProperty
Error: src/features/mapSideBar/management/ManagementView.test.tsx(90,36): error TS2345: Argument of type '{ error: any; response: any; execute: Mock<any, any>; loading: boolean; status: number; }' is not assignable to parameter of type '{ ltsaRequestWrapper: IResponseWrapper<(pid: string) => Promise<AxiosResponse<LtsaOrders, any>>>; getStrataPlanCommonProperty: IResponseWrapper<...>; }'.
Error: src/features/mapSideBar/property/MotiInventoryHeader.test.tsx(14,7): error TS2739: Type '{ pid: undefined; pin: undefined; id: undefined; ltsaOrders: undefined; pimsProperty: undefined; propertyAssociations: undefined; parcelMapFeatureCollection: undefined; geoserverFeatureCollection: undefined; bcAssessmentSummary: undefined; crownTenureFeatures: undefined; }' is missing the following properties from type 'ComposedProperty': planNumber, spcpOrder
Error: Process completed with exit code 2.

asanchezr
asanchezr reviewed Jul 4, 2025
View reviewed changes
source/frontend/src/features/mapSideBar/property/PropertyContainer.tsx Outdated
<LtsaPlanTabView
spcpData={composedPropertyState.spcpWrapper?.response}
ltsaRequestedOn={composedPropertyState.spcpWrapper?.requestedOn}
loading={composedPropertyState.ltsaWrapper?.loading ?? false}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is using the loading indicator from the wrong property (it seems to me). Shouldn't it be like the following instead?

Suggested change
loading={composedPropertyState.ltsaWrapper?.loading ?? false}
loading={composedPropertyState.spcpWrapper?.loading ?? false}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good catch. updated.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4881

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4881

@eddherrera eddherrera requested a review from asanchezr July 4, 2025 18:10
asanchezr
asanchezr reviewed Jul 4, 2025
View reviewed changes
source/frontend/src/features/mapSideBar/property/tabs/ltsa/LtsaPlanTabView.tsx Outdated
<>
<LoadingBackdrop show={loading} parentScreen={true} />

{!loading && planNumber && !spcpData ? (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
{!loading && planNumber && !spcpData ? (
{!loading && exists(planNumber) && !exists(spcpData) ? (

asanchezr
asanchezr reviewed Jul 4, 2025
View reviewed changes
source/frontend/src/features/mapSideBar/property/tabs/ltsa/LtsaPlanTabView.tsx Outdated
enableReinitialize={true}
>
<StyledForm>
{ltsaRequestedOn && (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
{ltsaRequestedOn && (
{exists(ltsaRequestedOn) && (

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4881

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4881

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4881

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4881

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4881

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4881

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 4, 2025

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4881

@eddherrera eddherrera merged commit dfc669b into bcgov:dev Jul 4, 2025
13 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/4881

@eddherrera eddherrera deleted the psp-10194 branch July 4, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asanchezr asanchezr asanchezr approved these changes

@FuriousLlama FuriousLlama Awaiting requested review from FuriousLlama

@devinleighsmith devinleighsmith Awaiting requested review from devinleighsmith

Assignees

@eddherrera eddherrera

Labels
5.11 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddherrera @asanchezr