Refactor backend stack to explicitly transpile code

In order to improve performance and avoid typescript issues during runtime, we are compiling first instead of transpiling on the fly. Signed-off-by: Jeremy Ho <[email protected]>
bcgov · Dec 19, 2023 · 0886eab · 0886eab
1 parent b819c72
commit 0886eab
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 7 deletions.
diff --git a/.dockerignore b/.dockerignore
@@ -9,6 +9,7 @@ dist
 files
 **/e2e/videos
 node_modules
+sbin
 # Ignore only top-level package-lock.json
 /package-lock.json
 

diff --git a/.gitignore b/.gitignore
@@ -9,6 +9,7 @@ dist
 files
 **/e2e/videos
 node_modules
+sbin
 # Ignore only top-level package-lock.json
 /package-lock.json
 

diff --git a/Dockerfile b/Dockerfile
@@ -42,7 +42,7 @@ WORKDIR ${APP_ROOT}
 # Install Application
 RUN chown -R 1001:0 ${APP_ROOT}
 USER 1001
-RUN npm ci --omit=dev
+RUN npm ci --omit=dev && npm run build
 
 EXPOSE ${APP_PORT}
-CMD ["node", "-r", "ts-node/register", "./bin/www"]
+CMD ["node", "./sbin/bin/www"]
diff --git a/app/.gitignore b/app/.gitignore
@@ -9,6 +9,9 @@ dist
 files
 **/e2e/videos
 node_modules
+sbin
+# Ignore only top-level package-lock.json
+/package-lock.json
 
 # Ignore Helm subcharts
 charts/**/charts

diff --git a/app/app.ts b/app/app.ts
@@ -93,7 +93,8 @@ appRouter.get('/api', (_req: Request, res: Response): void => {
 });
 
 // Host the static frontend assets
-appRouter.use('/', express.static(join(__dirname, 'dist')));
+// This route assumes being executed from '/sbin'
+appRouter.use('/', express.static(join(__dirname, '../dist')));
 
 // Mount application endpoints
 app.use('/', appRouter);

diff --git a/app/package.json b/app/package.json
@@ -6,9 +6,12 @@
   "author": "NR Common Service Showcase <[email protected]>",
   "license": "Apache-2.0",
   "scripts": {
-    "build": "ts-node ./frontend-utils.ts",
-    "clean": "rimraf coverage dist",
-    "clean:all": "npm run clean && ts-node ./frontend-utils.ts clean",
+    "build": "tsc",
+    "build:all": "ts-node ./frontend-utils.ts",
+    "postbuild:all": "npm run build",
+    "clean": "rimraf coverage dist sbin",
+    "clean:all": "ts-node ./frontend-utils.ts clean",
+    "postclean:all": "npm run clean",
     "debug": "ts-node-dev --debug --respawn --transpile-only --rs --watch bin,config,dist ./bin/www",
     "format": "prettier ./src --write",
     "lint": "eslint . **/www* --no-fix --ext .js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --ignore-path .gitignore",

diff --git a/app/tsconfig.json b/app/tsconfig.json
@@ -44,7 +44,7 @@
     // "emitDeclarationOnly": true,                      /* Only output d.ts files and not JavaScript files. */
     // "sourceMap": true,                                /* Create source map files for emitted JavaScript files. */
     // "outFile": "./",                                  /* Specify a file that bundles all outputs into one JavaScript file. If 'declaration' is true, also designates a file that bundles all .d.ts output. */
-    "outDir": "./dist" /* Specify an output folder for all emitted files. */,
+    "outDir": "./sbin" /* Specify an output folder for all emitted files. */,
     // "removeComments": true,                           /* Disable emitting comments. */
     // "noEmit": true,                                   /* Disable emitting files from a compilation. */
     // "importHelpers": true,                            /* Allow importing helper functions from tslib once per project, instead of including them per-file. */