Feature/highlight selected version #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the button would be hidden for the currently selected version.
Coverage Report (Application)
|
Coverage Report (Frontend)
|
TimCsaky
approved these changes
Aug 8, 2023
TimCsaky
approved these changes
Aug 8, 2023
jujaga
reviewed
Aug 8, 2023
The currently selected row gets highlighted as well, so having that alongside striped rows increases visual clutter
Forgot to remove style for current version row highlighting after moving/renaming it in 51169f)
jujaga
approved these changes
Aug 8, 2023
See 4ffbd4 for context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The currently selected version in the "Versions" table is now highlighted. I used the existing
$bcbox-highlight-backgroundfor the highlight colour, but not sure if might be a bit too subtle.The "download" button for each version is now displayed even for the currently selected version.
https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3279
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments
There seems to be an existing bug for BCeID users where action buttons aren't displayed for all versions, even when the BCeID user has the required permissions.