Replace table role with treegird for screenreader #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
|
Code Climate has analyzed commit 3fbc4b8 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 66.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 24.7% (0.0% change). View more on Code Climate. |
Coverage Report (Frontend)
|
TimCsaky
reviewed
May 14, 2024
frontend/src/assets/main.scss
Outdated
| table tbody, | ||
| table tbody tr td:focus-visible{ | ||
| outline: 0 none; | ||
| box-shadow: inset 0px 0px 0 0.1rem #a6d5fa; |
There was a problem hiding this comment.
we used a width or 0.2rem for the anchors. (see line 83).
maybe this should also be: box-shadow: 0 0 0 0.2rem #a6d5fa; or we make them all 0.1rem
There was a problem hiding this comment.
I tried that earlier but it does not seems to be working for td and hiding left and bottom shadow. .2rem should work.
TimCsaky
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Table role to treegrid
Change cell role to treeitem
Tab Navigation across table
Make sure screen reader readout navigation buckets
SC3689
Description
Types of changes
Checklist
Further comments