Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send invite in email notification #200

Merged
merged 7 commits into from
May 21, 2024
Merged

Send invite in email notification #200

merged 7 commits into from
May 21, 2024

Conversation

TimCsaky
Copy link
Contributor

@TimCsaky TimCsaky commented May 17, 2024

Description

https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3598

Enable email notification for invites.

  • when scoping invite, email invitee
  • only show invite url for open invites (a feature soon to be retired)
  • call CHES api via the server-side/backend of BCBox
  • authenticate request from browser to bcbox backend api using authorization middleware
  • authenticate call to CHES with client credentials
  • use CHES email merge feature

note: For some reason the deployment config didnt get updated .. so i have manually edited it for the PR deployment only.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

frontend/src/services/interceptors.ts Show resolved Hide resolved
app/src/middleware/authentication.ts Show resolved Hide resolved
app/src/services/email.ts Show resolved Hide resolved
frontend/src/services/inviteService.ts Show resolved Hide resolved
frontend/src/services/inviteService.ts Show resolved Hide resolved
Copy link

codeclimate bot commented May 17, 2024

Code Climate has analyzed commit 66c8431 and detected 10 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 5
Duplication 2
Bug Risk 3

The test coverage on the diff in this pull request is 6.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.2% (-0.4% change).

View more on Code Climate.

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

github-actions bot commented May 17, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 19.17% ( 709 / 3698 )
Methods: 18.57% ( 135 / 727 )
Lines: 22.95% ( 493 / 2148 )
Branches: 9.84% ( 81 / 823 )

app/src/routes/v1/index.ts Fixed Show fixed Hide fixed
@TimCsaky TimCsaky marked this pull request as draft May 17, 2024 20:51
@TimCsaky TimCsaky marked this pull request as ready for review May 17, 2024 23:30
@norrisng-bc norrisng-bc merged commit 57fc13b into master May 21, 2024
18 of 19 checks passed
@norrisng-bc norrisng-bc deleted the feature/email branch May 21, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants