Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Navigation for configure folder #214

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Tab Navigation for configure folder #214

merged 1 commit into from
Jun 19, 2024

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented Jun 18, 2024

  • Tab Navigation for Config folder
  • Focus fixes for share and config buttons
  • added aria labels

SC3686

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

github-actions bot commented Jun 18, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 18.29% ( 751 / 4105 )
Methods: 17.88% ( 138 / 772 )
Lines: 22.57% ( 530 / 2348 )
Branches: 8.43% ( 83 / 985 )

Copy link

codeclimate bot commented Jun 18, 2024

Code Climate has analyzed commit 77496c7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 23.7% (-0.1% change).

View more on Code Climate.

@jatindersingh93 jatindersingh93 marked this pull request as ready for review June 18, 2024 23:47
@TimCsaky TimCsaky merged commit f27cb89 into master Jun 19, 2024
18 of 19 checks passed
@jatindersingh93 jatindersingh93 deleted the SC3686 branch June 22, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants