Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify exsting users with invite #218

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Notify exsting users with invite #218

merged 1 commit into from
Jun 24, 2024

Conversation

TimCsaky
Copy link
Contributor

For the share feature, also notify existing users where result is just a permission update.

Description

ticket: https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3702
For the share feature, also notify existing users where result is just a permission update.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

For the share feature, also notify existing users where result is just a permission update.
Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 18.06% ( 754 / 4174 )
Methods: 17.82% ( 139 / 780 )
Lines: 22.27% ( 532 / 2389 )
Branches: 8.26% ( 83 / 1005 )

Copy link

codeclimate bot commented Jun 24, 2024

Code Climate has analyzed commit 2ad312f and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 4

The test coverage on the diff in this pull request is 4.2% (50% is the threshold).

This pull request will bring the total coverage in the repository to 23.4% (-0.3% change).

View more on Code Climate.

@TimCsaky TimCsaky merged commit b6d584a into master Jun 24, 2024
18 of 19 checks passed
@TimCsaky TimCsaky deleted the invite-notify branch June 24, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants