Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Navigation to Delete button #219

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Add Navigation to Delete button #219

merged 1 commit into from
Jun 26, 2024

Conversation

jatindersingh93
Copy link
Contributor

@jatindersingh93 jatindersingh93 commented Jun 26, 2024

Focus should be the entire popup box and it should read out entire content
Focus should go back to the details icon button once close is hit

SC3689

Description

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

github-actions bot commented Jun 26, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 18.13% ( 760 / 4193 )
Methods: 17.94% ( 141 / 786 )
Lines: 22.31% ( 536 / 2402 )
Branches: 8.26% ( 83 / 1005 )

Copy link

codeclimate bot commented Jun 26, 2024

Code Climate has analyzed commit fecdf96 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 23.5% (0.0% change).

View more on Code Climate.

@TimCsaky TimCsaky merged commit d56fa81 into master Jun 26, 2024
18 of 19 checks passed
@TimCsaky TimCsaky deleted the SC3689 branch June 26, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants