Restrict non-idir user features #307
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Release 991d72b deployed at https://coms-dev-pr-307.apps.silver.devops.gov.bc.ca |
Coverage Report
|
app/src/middleware/authorization.js
Outdated
| req.currentUser.tokenPayload.identity_provider !== 'idir' && | ||
| !hasOnlyPermittedKeys(req.query, ['email', 'userId', 'identityId']) | ||
| ) { | ||
| throw new Error('User lacks permission to complete this actionnn'); |
| @@ -72,6 +72,11 @@ const utils = { | |||
| return key || '/'; // set empty key to '/' to match convention in COMS db | |||
| }, | |||
|
|
|||
| hasOnlyPermittedKeys(obj, permittedKeys) { | |||
| const objKeys = Object.keys(obj); | |||
| return objKeys.every(key => permittedKeys.includes(key)); | |||
There was a problem hiding this comment.
will this allow empty object? may be adding 'objKeys.length > 0 &&' will help?
TimCsaky
commented
May 28, 2025
TimCsaky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of changes
Checklist
Further comments