Refactor/evaluation schema #492
Conversation
There was a problem hiding this comment.
Nice work, @IanFonzie ! I left a couple of comments clarifying some items, and one minor suggestion on module organization.
| EvaluationTeamQuestionsReview = "EVAL_QUESTIONS_REVIEW", | ||
| EvaluationTeamQuestionsChairSubmission = "EVAL_QUESTIONS_CHAIR_SUBMISSION", | ||
| EvaluationTeamQuestionsAdminReview = "EVAL_QUESTIONS_ADMIN_REVIEW", | ||
| EvaluationTeamQuestions = "EVAL_QUESTIONS", // TODO: Remove |
There was a problem hiding this comment.
Confirming you are aware of this TODO to address later?
| UnderReviewTeamQuestions = "UNDER_REVIEW_QUESTIONS", // TODO: Remove | ||
| EvaluatedTeamQuestions = "EVALUATED_QUESTIONS", // TODO: Remove |
There was a problem hiding this comment.
Confirming you are aware of these TODOs to address later?
There was a problem hiding this comment.
I understand why it's simpler to keep these functions in a single module instead of mapping the DB modules to match the resource modules. However, I would recommend renaming this file from db/question-evaluation/sprint-with-us.ts to db/evaluations/sprint-with-us/team-questions.ts for clarity.
There was a problem hiding this comment.
IIRC the plan is to move the question-evaluation pages to their correct locations post launch?
|
Refactoring to the DB, front-end, and back-end that addresses changes from our 03-05-25 and 03-07-25 meetings.