Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dataclass annotation #127

Merged
merged 10 commits into from
Nov 7, 2024
Merged

Feature/dataclass annotation #127

merged 10 commits into from
Nov 7, 2024

Conversation

rustyjux
Copy link
Contributor

@rustyjux rustyjux commented Nov 6, 2024

Description

Fixes:

Supports the creation of routes in Openshift with a data class annotation. This is required for routes on Emerald with data class != low as per as per https://digital.gov.bc.ca/cloud/services/private/internal-resources/emerald/#:~:text=How%20to%20assign%20security%20classifications%20to%20routes.

Data class annotations on routes are added via the addition of a tag on a service in gateway config with format aps.route.dataclass.CLASS with acceptable classes of low, medium, high, public. Validation will be put in place to ensure this tag is only used on services.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (non-breaking change with enhancements to documentation) - to be completed in APS-3042
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate) - to be completed in APS-3042

@rustyjux rustyjux merged commit 67a55ba into dev Nov 7, 2024
7 checks passed
@rustyjux rustyjux deleted the feature/dataclass-annotation branch November 7, 2024 17:59
rustyjux added a commit that referenced this pull request Nov 7, 2024
Feature/dataclass annotation (#127)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants