Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of issue 37
About the von-image:next-2 and why it is not perfect :)
This image contains old versions of indy-vdr (version 0.2.0).. and the installation if this package is a little bit crazy because the python package, installed there, already contains the
libindy_vdr.so
and it is not necessary to install it into$HOME/.local/lib
(i would create an issue in von-image repo for that).So you can see, that i removed the
/home/indy/.local/lib/libindy_vdr.so
in Dockerfile (as workaround) and updated indy-vdr via pip3 andrequirements.txt
.I hope, after the von-image is fixed and next-3 version is built, we can switch to this version and remove this workaround!
FYI:
The integration tests are successful (tested with von-network and
manage test
)