Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1694 lock ownership to read only #1712

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

xiaopeng0202
Copy link
Collaborator

@xiaopeng0202 xiaopeng0202 commented Nov 7, 2024

This pull request introduces a new API endpoint to retrieve seedlot information by seedlot number and integrates this functionality into the frontend. The changes include updates to the API configuration, addition of a new endpoint in the backend, and modifications to the frontend components to utilize this new endpoint.

New

  • lock ownership to read only when original qty is over 0
  • added new endpoint on oracle db to expose original qty from seedlot table

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@xiaopeng0202 xiaopeng0202 changed the title Feat/1694 lock ownership to read only Feat: 1694 lock ownership to read only Nov 7, 2024
@xiaopeng0202 xiaopeng0202 marked this pull request as draft November 7, 2024 21:27
@xiaopeng0202 xiaopeng0202 marked this pull request as ready for review November 7, 2024 21:35
@xiaopeng0202 xiaopeng0202 reopened this Nov 7, 2024
@DerekRoberts
Copy link
Member

DerekRoberts commented Nov 7, 2024

@xiaopeng0202 Any sense writing a test to ensure read only?

@xiaopeng0202 xiaopeng0202 reopened this Nov 8, 2024
@DerekRoberts DerekRoberts changed the title Feat: 1694 lock ownership to read only feat: 1694 lock ownership to read only Nov 12, 2024
@SLDonnelly SLDonnelly closed this Nov 12, 2024
@SLDonnelly SLDonnelly reopened this Nov 12, 2024
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
Added only a few markups, but nothing major.

frontend/src/api-service/ApiConfig.ts Outdated Show resolved Hide resolved
frontend/src/api-service/seedlotAPI.ts Outdated Show resolved Hide resolved
oracle-api/config/application-local.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants