feat: ORV2-2857 - Update DDL model of Receipt and Transaction #1647
Conversation
praju-aot
requested review from
gchauhan-aot and
john-fletcher-aot
as code owners
|
|
||
| IF @@ERROR <> 0 SET NOEXEC ON | ||
| GO | ||
| AlTER TABLE [permit].[ORBC_RECEIPT_HIST] ALTER COLUMN [TRANSACTION_ID] [bigint] NOT NULL |
There was a problem hiding this comment.
This will fail if there were any purchases / refunds in between when the update and revert script ran. Maybe we keep it NULLable once it's been set as such in the history table? Low chance of this occurring but still a possibility then it would be a real problem.
There was a problem hiding this comment.
I am planning to request downtime just to be on the safe side
| DECLARE @VersionDescription VARCHAR(255) | ||
| SET @VersionDescription = 'Reverting addition of RECEIPT_ID col to ORBC_TRANSACTION and dropping TRANSACTION_ID from ORBC_RECEIPT.' | ||
|
|
||
| INSERT [dbo].[ORBC_SYS_VERSION] ([VERSION_ID], [DESCRIPTION], [RELEASE_DATE]) VALUES (45, @VersionDescription, getutcdate()) |
There was a problem hiding this comment.
Best to keep this inside the transaction - I'd follow the pattern of v_38_ddl_revert.sql
There was a problem hiding this comment.
I mean, this should technically work as-is though it doesn't have the user message output like v_38, and nice to keep to a minimum number of different patterns
|
|
|
|
|
Description
Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.
Update the relation and data model of ORBC_RECEIPT and ORBC_TRANSACTION to facilitate refund to multiple payment methods.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are promoted to: