Add option to generate TS string enums #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcherny
requested changes
Mar 2, 2024
Added e2e test |
|
@bcherny ping. |
|
@bcherny ping 2 - all work and changes requested are completed |
|
How come this one is still not merged? I addressed all change requests and am updating all conflicts regularly. Can we merge this one please? |
bcherny
approved these changes
Jun 25, 2024
|
Mind rebasing one last time? |
|
Rebased |
|
Published [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue: #200
Addressed comments/requests in: #262 (review)
Implemented as a normalizer under cli/options flag:
inferStringEnumKeysFromValues