Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build #621

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix build #621

merged 1 commit into from
Aug 20, 2024

Conversation

benmccann
Copy link
Contributor

npm run build is currently failing. This fixes it

@bcherny
Copy link
Owner

bcherny commented Aug 20, 2024

How are you running the build? It seems to work fine https://github.com/bcherny/json-schema-to-typescript/actions/runs/10434515274

@benmccann
Copy link
Contributor Author

I just ran npm run build from the CLI locally. It gives me:

> browserify src/index.ts -s jstt -p tsify > dist/bundle.js


node_modules/parse-json/index.js:33
		throw jsonErr;
		^
ErrorEXError [JSONError]: Trailing comma in array at 8:5 in tsconfig.json
    ],
    ^
    ],
    ^

@bcherny
Copy link
Owner

bcherny commented Aug 20, 2024

Ah, you're right! We don't run the client build in CI, so CI works fine. Thanks for the fix.

@bcherny bcherny merged commit cb99ce4 into bcherny:master Aug 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants