Add a folder copy flag #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new CLI flag (--copy) to allow users to copy over folders into the destination directory, supporting legacy assets integration.
- Updated tests to exercise folder copying behavior.
- Fixed spelling issues in warning messages and variable names.
- Integrated copy functionality into the builder and updated related docs.
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test-cases/nested-dest/index.test.js | Modified TopBun instantiation to include copy flag. |
| test-cases/general-features/index.test.js | Updated test to include copied folder assets. |
| lib/identify-pages.js | Fixed spelling of "templateFileName". |
| lib/helpers/top-bun-warning.js | Fixed typo in warning code identifier. |
| lib/builder.js | Integrated build-copy step into the builder flow. |
| lib/build-copy/index.test.js | Added tests for getCopyDirs functionality. |
| lib/build-copy/index.js | Implemented copy functionality using cpx2. |
| index.js | Updated TopBun class to incorporate copy directories. |
| bin.js | Added command-line parsing support for the copy flag. |
| README.md | Updated documentation to explain the --copy flag. |
Files not reviewed (2)
- test-cases/general-features/copyfolder/oldsite/styles/globals.css: Language not supported
- test-cases/general-features/copyfolder/some.type: Language not supported
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag to the CLI that lets you copy over a folder on top of the dest folder. If you have assets from an old site, it gives a clear way to cope that into a top-bun website without having to reason about tb rules.