add BBB Servo cape overlay #173
Conversation
|
@RobertCNelson Are we using BeagleBone cape manager to load DT cape overlays on BBAI? The recent patch suggests we are not using it with BBAI. I would like to work on this, If you have any good reading material on Cape manager please share :) |
|
@lorforlinux at the time of the version of u-boot that we ship for the BBAI's I was unable to get the header based i2c port to work in u-boot SPL.. |
jadonk
left a comment
jadonk
left a comment
There was a problem hiding this comment.
Thanks for this! Looking forward to BeagleBone AI compatibility for it and test results.
| }; | ||
|
|
||
| &i2c2 { | ||
| pinctrl-names = "default"; |
There was a problem hiding this comment.
Is your editor using tabs or not? The style should be like for Linux, with tabs.
There was a problem hiding this comment.
Yes, my editor is using tabs.
| #size-cells = <0>; | ||
|
|
||
| pca9685_servo: pca9685_serve@7f { | ||
| compatible = "nxp, pca9685"; |
There was a problem hiding this comment.
Is there supposed to be a space in "nxp, pca9685"? Maybe I don't remember properly, but I recall no spaces in these compatible strings.
There was a problem hiding this comment.
I think there should not be any space.
| }; | ||
|
|
||
| &{/} { | ||
| gpio_inputs { |
There was a problem hiding this comment.
I don't think these are actual input pins to the Beagle. I'm not sure what they are, but I think they are just configuration pins for the device.
There was a problem hiding this comment.
Please review this updated pull request here -> #174
3 participants
@RobertCNelson Please review my code :)