-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBB and BBAI compatible relayCape overlay #186
base: master
Are you sure you want to change the base?
Conversation
To make it compatible for both BBB and BBAI by using code from beagleboard/BeagleBoard-DeviceTrees/pull/17 and new DT format.
This DT is using code from beagleboard/BeagleBoard-DeviceTrees/pull/17 to create compatible led_P8_* / led_P8_* nodes for both BBB and BBAI. Rewritten and based on the BBORG_RELAY-00A2.dts written by Robert Nelson & Amilcar Lucas for kernel <=4.14
Nak, I'm not committing anything that breaks v4.14 booting. |
@RobertCNelson I understand your concern but, If we don't include the compatibility code it will break on v4.19 also. if we include the compatibility code then this will work on both v4.14 and v4.19. |
i didn't want to do this.. but let's do like the pi: https://github.com/raspberrypi/linux/tree/rpi-4.19.y/arch/arm/boot/dts/overlays overlays back in teh kernel *.deb Regards, |
I am not sure about that. |
Let's try this a different way... Fred a user just installed the spring 2020 release, he is using this cape. Like a normal use he runs apt update/apt upgrade and then reboots expecting the board to reboot. But with this change u-boot throws an fdt error and locks up. Fred throws board in trash. Your changes are making us force the user to update there kernel dtb. The only real fix is to move these back into the kernel package so that all changes are synced between overlay and kernel dtb. |
well, there should be some reason behind switching to uBoot overlays in the first place right? |
Huh? u-boot overlays has been the only workable option for the last few years, that is not changing here.. |
Okay, can you please tell me how will all this work out?
I think we have to create an overlays folder with required files here -> https://github.com/beagleboard/linux/tree/4.19-rt/arch/arm/boot/dts |
Another, con: config-pin currently ships in "bb-cape-overlays" debian package which this idea will EOL.. Transitioning a binary from one debian package to a new one, is always a pain and easy to break..
Considering there is no "other" way for the BBAI, how exactly are you loading the overlay.. Regards, |
You are suggesting to shift overlays from
Actually I am not familiar with this ^ |
Can we put these on a new branch and have this be the way for things August release and newer? Kinda stinks that the old stuff will just update from master and that the base tree dependencies aren't here because it was never packaged. This really should have been released to users in a way that could depend on kernel/base-tree versions. Maybe we can keep some old stuff but make the August release a starting point to add that kernel dependency into releasing these overlays?!? @RobertCNelson |
@jadonk @RobertCNelson please review my code :)
Everything has been tested on BBB and BBAI.