Batch 5 changesets #254
Merged
Batch 5 changesets #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing 500 error on LC and memory errors on server when beaker_pxemenu hourly cron job attempts to gather distros to generate pxemenus. Instead of trying to gather all distros at one time, the code will gather in batches by architecture. This appears to be more efficient for pxemenu since the code no longer needs to parse the entire list over and over again to select distros by arch to create new lists since it's gathered in that order.
RHEL10 made network changes which was randomly causing installs to fail. The bootproto option was removed from the network command for wheh no_networks is NOT set. This alleviated the problem users were seeing. This change applies to all RHEL releases 10 and above.
Unable to retry fetch operations for latest Fedora releases and RHEL-9+. These distros have an extra option in the `curl help` in order to find the retry option help text. Instead of just `curl --help` they use `curl --help all`. Because help not working as expected, current code unable to determine whether the `retry` option is available for `curl` so retry not performed.
StykMartin
requested review from
a team,
StykMartin,
JohnVillalovos,
p3ck and
mdujava
and removed request for
a team
There was a problem hiding this comment.
Copilot reviewed 2 out of 20 changed files in this pull request and generated no comments.
Files not reviewed (18)
- IntegrationTests/src/bkr/inttest/server/kickstarts/AtomicHost-defaults.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/Fedora18-harness-contained-custom.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/Fedora18-harness-contained.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/Fedora18-scheduler-defaults.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/Fedorarawhide-scheduler-defaults.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/RHVH-defaults.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/RedHatEnterpriseLinux6-manual-defaults-beaker-create-kickstart.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/RedHatEnterpriseLinux6-manual-defaults.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/RedHatEnterpriseLinux6-scheduler-defaults-beaker-create-kickstart.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/RedHatEnterpriseLinux6-scheduler-defaults.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/RedHatEnterpriseLinux6-scheduler-guest.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/RedHatEnterpriseLinux6-scheduler-manual.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/RedHatEnterpriseLinux7-scheduler-defaults.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/RedHatEnterpriseLinux7-scheduler-manual.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/RedHatEnterpriseLinuxAlternateArchitectures7-scheduler-defaults.expected: Language not supported
- IntegrationTests/src/bkr/inttest/server/kickstarts/RedHatEnterpriseLinuxServer5-scheduler-defaults.expected: Language not supported
- Server/bkr/server/snippets/fetch_wrapper: Language not supported
- Server/bkr/server/snippets/network: Language not supported
Comments suppressed due to low confidence (2)
LabController/src/bkr/labcontroller/pxemenu.py:176
- [nitpick] Please ensure that the concatenation order for ipxe_distrotrees matches the intended priority, as the ordering is different from that used for the x86_distrotrees. If the order matters for boot menu generation, consider documenting or aligning it.
ipxe_distrotrees = arch_distrotrees['x86_64'] + arch_distrotrees['aarch64'] + \
IntegrationTests/src/bkr/inttest/server/test_kickstart.py:3029
- [nitpick] Ensure that the removal of bootproto in the network configuration is properly reflected in the rendered kickstart output, and verify that the extra whitespace in the network line is intentional.
network --hostname=test01.test-kickstart.invalid
JohnVillalovos
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pxemenu to get distro batched by arch
Remove bootproto in network snippet for RHEL10+
Fix curl help in fetch_wrapper for newer releases