Skip to content

Tox testing #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: python-3
Choose a base branch
from
Open

Tox testing #257

wants to merge 8 commits into from

Conversation

pablmart
Copy link

Run using uv and tox the existing unit tests for
Global
Common
Server
Lab Controller
Client

In a github actions workflow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this run all the test suites (Server, LabController, etc).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does, but the actions are not active in this branch somehow

matrix:
env:
- "3.10"
- "3.9"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have the results of these jobs running on GitHub?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohnVillalovos JohnVillalovos requested a review from Copilot June 13, 2025 12:53
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configuration to run unit tests using tox and uv via a GitHub Actions workflow. It aims to execute tests for Common, Server, Lab Controller, and Client across different Python versions.

  • Adds a tox.ini file defining the test environment, dependencies, and nosetests command.
  • Introduces a GitHub Actions workflow to install dependencies with uv and execute tox-based tests.
  • Configures matrix builds to test multiple Python versions and libraries.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
tox.ini Defines the test environment, dependency list, and commands.
.github/workflows/run-tox-tests.yml Sets up a GitHub Actions job to run tox tests using uv.
Comments suppressed due to low confidence (1)

.github/workflows/run-tox-tests.yml:30

  • Using both '--with ${{ matrix.library }}/' and '--with Common/' may lead to redundancy if matrix.library is set to 'Common'. Verify that this dual inclusion is intentional and clearly documented.
run: uv tool install --python-preference only-managed --python ${{ matrix.env }} tox --with ${{ matrix.library }}/ --with Common/

daemon
SQLAlchemy

commands = nosetests -v -w . Common {env:TOXLIB}
Copy link
Preview

Copilot AI Jun 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command line mixes a hard-coded 'Common' with a dynamic environment variable {env:TOXLIB}. Consider clarifying or consolidating the directories being tested to avoid potential duplication or ambiguity.

Suggested change
commands = nosetests -v -w . Common {env:TOXLIB}
commands = nosetests -v -w . {env:TOXLIB}/Common {env:TOXLIB}

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants