default-file improvements #1838
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minion3665
force-pushed
the
push-uuwsqwsunqtu
branch
3 times, most recently
from
9cc82de to
f4ca2e6
Compare
It's a common point of confusion that default-file does not set the default file for insertions. This patch brings the behavior into line with people's expectations. BREAKING-CHANGE: If you are using default-file and expecting entries to be inserted to your main file, this will no longer happen Fixes: beancount#882 Refs: beancount#1698, beancount#822
I autogenerate some fava config, and one option I'd like to specify is the default file. Unfortunately, this previously had to be specified in the file which would become the default file, leading to a messy and fragile setup in which my (readonly) configuration file would become the default if the magical "default-file" line was ever removed from the user-editable config. This feature allows existing semantics around default-file to continue, while also providing the ability to set it in some other file if the existing options are unsuitable.
Minion3665
force-pushed
the
push-uuwsqwsunqtu
branch
from
f4ca2e6 to
3ff9ec6
Compare
yagebu
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 of 2:
It's a common point of confusion that default-file does not set the
default file for insertions. This patch brings the behavior into line
with people's expectations.
BREAKING-CHANGE: If you are using default-file and expecting entries to be inserted to your main file, this will no longer happen
Fixes: #882
Refs: #1698, #822
2 of 2:
I autogenerate some fava config, and one option I'd like to specify is
the default file.
Unfortunately, this previously had to be specified in the file which
would become the default file, leading to a messy and fragile setup in
which my (readonly) configuration file would become the default if the
magical "default-file" line was ever removed from the user-editable
config.
This feature allows existing semantics around default-file to continue,
while also providing the ability to set it in some other file if the
existing options are unsuitable.