Skip to content

Do not filter out non-Transaction entries #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Evernight wants to merge 1 commit into from
Closed

Do not filter out non-Transaction entries #1969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/fava/core/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

import ply.yacc # type: ignore[import-untyped]
from beancount.core import account
from beancount.core.data import Transaction
from beancount.ops.summarize import clamp_opt

from fava.beans.account import get_entry_accounts
Expand Down Expand Up @@ -445,7 +446,11 @@ def __init__(self, value: str) -> None:

def apply(self, entries: Sequence[Directive]) -> Sequence[Directive]:
include = self._include
return [entry for entry in entries if include(entry)]
return [
entry
for entry in entries
if include(entry) or not isinstance(entry, Transaction)
]


class AccountFilter(EntryFilter):
Expand All @@ -472,4 +477,5 @@ def apply(self, entries: Sequence[Directive]) -> Sequence[Directive]:
account.has_component(name, value) or match(name)
for name in get_entry_accounts(entry)
)
or not isinstance(entry, Transaction)
]
Loading