Open
Conversation
2a1e07c to
992030b
Compare
Author
|
Maybe it would be a good time to remove support for PHP 7.2 and 8.0 as they are not maintained anymore. Is that worth considering or do I miss something due to my lack of experience in the open source @beberlei? |
Author
|
Hello @derrabus, do you know when are released new major and/or minor versions for this repository? By looking at the dates of the previous ones, I did not find defined periods. It will help me to understand when pull requests are merged. Thank you for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows to use the Oracle
NVL2function.Also, the missing
lintcommand described in the README.md was added in thecomposer.json.It is based on the GitHub Actions workflows which led me to the ones defined in the Doctrine repository (PHP_CodeSniffer, PHPStan).
By the way, PHPStan found the following errors: