Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] pos_eater #533

Open
wants to merge 46 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] pos_eater #533

wants to merge 46 commits into from

Conversation

carmenbianca
Copy link
Collaborator

Description

Migrate pos_eater. Effectively a complete rewrite.

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#id=11294&action=475&active_id=492&model=project.task&view_type=form&menu_id=536

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

mclaeysb and others added 30 commits April 29, 2024 16:50
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Override default data so as to set encoding to EAN-13.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
…ders by email' (replace with OCA module)

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
[REF] __manifest__: add licence, remove description

[REF] add Coop IT Easy SCRLfs to authors

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
maintains "Available in POS" (`available_in_pos`) value
when unchecking "Can be Sold" (`sale_ok`).

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
It does not feel write to completely take control over the code
written by many volunteers at the bees coop.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[UPD] Update beesdoo_pos.pot

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
…rent value between calls

Because of asynchronicity fun, get_client() would sometimes return null,
and thus raise an error.

Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
oca-ci and others added 15 commits April 29, 2024 16:58
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>

Regenerate all README.rst

Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[UPD] README.rst

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
[REF] put splitted modules as dependencies

[FIX] test-requirements

[FIX] remove beesdoo_base demo data in manifest

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
into:
- product_main_supplier
- sale_suggested_price
- sale_adapt_price_wizard

[REF] split beesdoo_product -> product_main_supplier

[FIX] sale_suggested_price dep on product_main_supplier

[ADD] module sale_edit_price_wizard

[REF] rename sale_edit_price_wizard ->  sale_adapt_price_wizard

[REF] move rounding_method to sale_suggested_price

[REF] refactor following PR 320

[REF] search product_code -> product_main_seller

[FIX] bug adapt_sales_price

[IMP] use float_compare to compare prices

[REF] move list_price_write_date to sale_adapt_price_wizard

[FIX] beesdoo_product: main_seller_id search

[FIX] run precommit

fix

Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[UPD] README.rst

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
into:
- pos_eater
- pos_available_in_pos_unlink -> cie-pos
- pos_forbid_new_customer -> moved to oca/pos
- pos_partner_no_create -> moved to oca/pos

[FIX] pos_auto_invoice,pos_eater: fix js module names

[FIX] pos_auto_invoice: missing js asset

[FIX] pos_eater: fix description

[FIX] beesdoo_pos: missing dependency

[FIX] pos_eater: data in manifest

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>

[UPD] README.rst

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Delete this module in advance of migrating pos_eater.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Comment on lines +15 to +19
<t t-if="props.partner.child_eater_ids">
<span class="eaters">
<t t-esc="eaterNames" />
</span>
</t>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is great, but if eaterNames is very long, the text disappears. See screenshot.

I do not know how to elegantly fix this.

Capture d’écran du 2024-05-02 14-47-55

Copy link
Collaborator Author

@carmenbianca carmenbianca May 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible to get rid of the padding on the right. There's a decentered option for this. This doesn't solve the problem, but universally gives more space.

Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Copy link
Collaborator

@polchampion polchampion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successful functional test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants