Skip to content

[16.0][MIG] sale product deposit #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: 16.0
Choose a base branch
from
Open

Conversation

mihien
Copy link

@mihien mihien commented Jul 2, 2025

Copy link
Member

@huguesdk huguesdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the pos part is used nowhere, it should be removed:

  • the point_of_sale dependency
  • the assets section of the manifest.
  • the static/src directory.
  • the views/assets.xml (leftover from 12.0).

apart from that, lgtm (but needs a functional test review).

"sale_product_deposit/static/src/js/models.js",
]
},
"installable": True,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this line can be removed.

victor-champonnois and others added 9 commits July 3, 2025 17:53
into:
- product_ingredients.
- product_hazard.
- sale_product_deposit.
- product_expiration.
- product_sale_limit_date.
- product_scale_label.
- product_barcode_generator.
- beesdoo_product_label
- product_label_print_request
- add deposit tax group (it was originally in the wrong module)
- fix call to the consigne group
- translate the tax group to english
@mihien mihien force-pushed the 16.0-mig-sale_product_deposit branch from 24ed6dd to 5cdc730 Compare July 3, 2025 16:45
@mihien mihien force-pushed the 16.0-mig-sale_product_deposit branch from 5cdc730 to 679edb8 Compare July 3, 2025 16:58
Copy link
Member

@victor-champonnois victor-champonnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review OK, just one line to remove from description

@@ -0,0 +1,2 @@
- Adds calculated total sales price with VAT, total sales price with VAT by reference unit, and deposit price on product templates (“General Information” tab).
- Display it in POS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this line, it's no longer true.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean the line "- Display it in POS"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants