-
Notifications
You must be signed in to change notification settings - Fork 41
[16.0][MIG] sale product deposit #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as the pos part is used nowhere, it should be removed:
- the
point_of_sale
dependency - the
assets
section of the manifest. - the
static/src
directory. - the
views/assets.xml
(leftover from 12.0).
apart from that, lgtm (but needs a functional test review).
sale_product_deposit/__manifest__.py
Outdated
"sale_product_deposit/static/src/js/models.js", | ||
] | ||
}, | ||
"installable": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also this line can be removed.
into: - product_ingredients. - product_hazard. - sale_product_deposit. - product_expiration. - product_sale_limit_date. - product_scale_label. - product_barcode_generator. - beesdoo_product_label - product_label_print_request
Signed-off-by: Carmen Bianca BAKKER <[email protected]>
- add deposit tax group (it was originally in the wrong module) - fix call to the consigne group - translate the tax group to english
24ed6dd
to
5cdc730
Compare
5cdc730
to
679edb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review OK, just one line to remove from description
@@ -0,0 +1,2 @@ | |||
- Adds calculated total sales price with VAT, total sales price with VAT by reference unit, and deposit price on product templates (“General Information” tab). | |||
- Display it in POS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this line, it's no longer true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean the line "- Display it in POS"
T12145