Remove an Extra Warning Filter in eventloop.py #598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version is smaller than 3.14 in the branch of the customly-defined RubiconEventLoop function, so there's no "deprecations in 3.14" to speak of when creating an event loop policy.
johnzhou721
commented
Jun 7, 2025
freakboy3742
reviewed
Jun 8, 2025
There was a problem hiding this comment.
You've misunderstood what is going on here.
Any attempt to instantiate EventLoopPolicy raises a warning in Python 3.13 or earlier, as a pre-warning to users that they need to adapt their code. The implementation of RubiconEventLoop on Python 3.13 and earlier uses the old API (which hasn't been deprecated on Python3.13 and earlier) to reproduce the behavior that will exist o Python 3.14+. If users have invoked RubiconEventLoop(), they've already done the adaptation that will be required to avoid the deprecation in future, so the warning can be silenced.
|
Sorry. "[H]ave been" meant that it's already done, but forgot that CPython has backports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version is smaller than 3.14 in the branch of the customly-defined RubiconEventLoop function, so there's no "deprecations in 3.14" to speak of when creating an event loop policy.
PR Checklist: