enable all errorprone checks by default and resolve their nit warnings · ben-manes/caffeine@5e5580a

Compute JMH Benchmark: caffeine/src/test/java/com/github/benmanes/caffeine/testing/ConcurrentTestHarness.java#L87

[UnnecessaryFinal] Since Java 8, it's been unnecessary to make local variables and parameters `final` for use in lambdas or anonymous classes. Marking them as `final` is weakly discouraged, as it adds a fair amount of noise for minimal benefit.

Compute JMH Benchmark: caffeine/src/test/java/com/github/benmanes/caffeine/testing/ConcurrentTestHarness.java#L87

[Var] Unnecessary 'final' modifier.

Compute JMH Benchmark: caffeine/src/test/java/com/github/benmanes/caffeine/testing/Threads.java#L73

[MemberName] Methods and non-static variables should be named in lowerCamelCase, with acronyms treated as words (https://google.github.io/styleguide/javaguide.html#s5.3-camel-case), but timeNS is not

Compute JMH Benchmark: caffeine/src/test/java/com/github/benmanes/caffeine/testing/LoggingEvents.java#L132

[Var] Non-constant variable missing @var annotation

Compute JMH Benchmark: caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L83

[MemberName] Methods and non-static variables should be named in lowerCamelCase, but get_function is not; did you mean 'getFunction'?

Compute JMH Benchmark: caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L112

[MemberName] Methods and non-static variables should be named in lowerCamelCase, but get_asMap is not; did you mean 'getAsMap'?

Compute JMH Benchmark: caffeine/src/test/java/com/github/benmanes/caffeine/lincheck/AbstractLincheckCacheTest.java#L117

[MemberName] Methods and non-static variables should be named in lowerCamelCase, but put_asMap is not; did you mean 'putAsMap'?

Compute JMH Benchmark: caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L115

[MethodCanBeStatic] A private method that does not reference the enclosing instance can be static

Compute JMH Benchmark: caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L138

[Var] Non-constant variable missing @var annotation

Compute JMH Benchmark: caffeine/src/test/java/com/github/benmanes/caffeine/cache/LocalCacheSubject.java#L165

[Var] Non-constant variable missing @var annotation

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable all errorprone checks by default and resolve their nit warnings #3527

benchmarks (21)

enable all errorprone checks by default and resolve their nit warnings #3527

Jobs

Run details

Annotations

benchmarks (21)

Re-running jobs...