Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore representing classic-style bonds as ActiveEffects #818

Open
rsek opened this issue Jun 24, 2023 · 0 comments
Open

Explore representing classic-style bonds as ActiveEffects #818

rsek opened this issue Jun 24, 2023 · 0 comments

Comments

@rsek
Copy link
Collaborator

rsek commented Jun 24, 2023

As of v11, ActiveEffects have a description field; at present, the bond object is {name: string, notes: string}, so the data migration would be pretty simple.

Potential benefits

  • bonds no longer tied to a specific item -- instead, 1 embedded document = 1 bond
  • take advantage of FVTT's various document methods and other utilities
  • use ActiveEffect#icon to provide a portrait or other image of the bond
  • represent system.bond ticks with an EffectChange; it'd be easy to adjust the number of ticks added by a specific bond
  • leverage code for shared ActiveEffects (in Implement impacts/debilities as ActiveEffects #770 ) to propagate shared bonds

Component changes

It's a bit of a departure from the current bonds manager, but I think the simplest solution would parallel progress item management: the list/overview of bonds gets its own tab, and editing an individual bond opens a new window.

The MVP could borrow heavily from our existing item list components. For the list view, the individual bond components should probably show only a name and an icon, arranged in a multiple-column thumbnail layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant