-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified models for progress tracks and clocks #820
Draft
rsek
wants to merge
48
commits into
ben:main
Choose a base branch
from
rsek:progress-model
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsek
changed the title
Unified models for all progress tracks and clocks
Unified models for progress tracks and clocks
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes of note (WIP)
progress
andtruth
JEPsProgressLike
data model; abstract class to provide constants and functions common to progress track-like objects (with the exception of classic bonds, which might get rewritten as part of Explore representing classic-style bonds asActiveEffect
s #818 , anyways)LegacyTrack
(extendsProgressLike
); each player character legacy track is now a single object whose source data is{ticks: number, xpSpent: number}
ProgressTrack
(extendsProgressLike
), which replaces every progress track that isn't a legacy track or bond trackticks
bond
renamed toconnection
; uses SF's "Forge a Bond" move when rolling progressdelve
, which is only used internally; it identifies delve progress tracks to progress-related methods; uses delve's "Locate Your Objective" move when rolling progresssystem.track
progress
JEP, which are intentionally more "atomic".Clock
data modelChallengeRankField
renamed toChallengeRank
; supplies most challenge rank constants and utility functions as statics