Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder-based move tree #882

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Folder-based move tree #882

wants to merge 14 commits into from

Conversation

rsek
Copy link
Collaborator

@rsek rsek commented Oct 1, 2023

building on #881 ; uses the compendium pack folder structure to build the move tree component, instead of dataforged.

TODO

  • pull in "custom moves" folder
  • re-implement IronFolder
    • consider moving some dataforged category => folder converters to static methods on IronFolder
  • update system.json to reflect that 11.313 is the minimum version
  • decide whether per-category caching is worth it (it probably isn't)
    • would this be a smaller PR if i made it world-moves only? i'd have to write a helper to get ppl started... but it'd let me strip out a lot of async code 🤔
  • give the delve site sheet a pass to make sure i haven't broke it
  • fix move jump link scrolling... again 😭
  • Update CHANGELOG.md

@rsek
Copy link
Collaborator Author

rsek commented Oct 5, 2023

this PR was complicated by: foundryvtt/foundryvtt#10034

but that bug is resolved as of 313, so i can re-implement the extended Folder class. this technically means it bumps the minor version requirement of the system; however, 313 also features an important security update, so i think that's fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant