Skip to content

Fixed issue in create_user #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benadida merged 2 commits into from
Jan 3, 2026
Merged

Fixed issue in create_user #370

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f85397
Fixed issue in `create_user`
crazyscientist Jan 31, 2023
cf6d1f5
Apply suggestion from @Copilot
benadida Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions helios_auth/auth_systems/password.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,13 @@

def create_user(username, password, name = None):
from helios_auth.models import User

user = User.get_by_type_and_id('password', username)
if user:
raise Exception('user exists')

try:
User.get_by_type_and_id('password', username)
Copy link

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result of User.get_by_type_and_id is not assigned to any variable. While the current code works correctly for checking existence, it would be more idiomatic to assign it to a variable (e.g., user = User.get_by_type_and_id('password', username)) for consistency with other usages in the codebase (see lines 65 and 90).

Suggested change
User.get_by_type_and_id('password', username)
user = User.get_by_type_and_id('password', username)

Copilot uses AI. Check for mistakes.
except User.DoesNotExist:
pass
else:
raise ValueError(f"user '{username}' already exists")

info = {'password' : password, 'name': name}
user = User.update_or_create(user_type='password', user_id=username, info = info)
Expand Down