-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: 4023228 ("let's exception not bubble") #3275
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 4023228. We use sys.exit. On purpose. We should therefore not be catching SystemExit.
This is probably wrong. But less wrong than handling *all* BaseException. Reports of this happening may be the result of some *other* async Timeout in the wsgi app bubbling through to us. Gevent docs promise: "[..] if *exception* is the literal ``False``, the timeout is still raised, but the context manager suppresses it, so the code outside the with-block won't see it."
@benoitc Recommend you test this in conjunction with the two patches by sylt. With those, it is no longer a "simple" revert, but gets us closer to confirming the spurious tracebacks reported in #3207 are dealt with. (hint: there is documentation on what exactly my integration tests currently encompass here: pajod#3) |
@pajod PR must be provided over the master and don't assume that other PR may be added. There is no guarantee a separate PR will be acccepted, so PR will be enough by itself. This PR sounds OK by itself. What could miss? |
There is not need to excessively produce high-severity logs, while there are ways to reach that point from entirely benign network errors. This partially reverts commit 0b10cba.
@benoitc This PR fits on current master. It is OK to merge by itself. |
The report in #2923 may have been not caused by a bug in Gunicorn or gevent in the first place. In any case, going from "this particular exception" to "each and every BaseException" was way excessive and is a likely explanation for #3207
Context:
Suggested changes:
Unfinished thoughts:
gunicorn/gunicorn/workers/geventlet.py
Lines 153 to 156 in 903792f