feat: etl integration #318
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarrothTheDragon
force-pushed
the
feat/etl
branch
from
1b447d9 to
0697e51
Compare
v-rocheleau
commented
Jul 24, 2025
lib/etl/docker-compose.etl.yaml
Outdated
| - ETL_CLIENT_ID=${BENTO_ETL_CLIENT_ID} | ||
| - ETL_CLIENT_SECRET=${BENTO_ETL_CLIENT_SECRET} | ||
| healthcheck: | ||
| test: [ "CMD", "curl", "http://localhost:${BENTO_ETL_INTERNAL_PORT}" ] |
There was a problem hiding this comment.
Should test the service-info endpoint (http://localhost:${BENTO_ETL_INTERNAL_PORT}/service-info), this way we test that the API is actually up
py_bentoctl/auth_helper.py
Outdated
Comment on lines
462
to
463
| # TODO: create a service account client for bento_etl (similar to WES) | ||
| # TODO: should output client secret after 'bentoctl init-auth' |
There was a problem hiding this comment.
rm comments, this is all implemented now
docs/etl.md
Outdated
| @@ -0,0 +1,68 @@ | |||
| # Bento ETL (Extract, Transform, Load) | |||
|
|
|||
| Bento ETL is a service that converts and uploads external data to Bento data services. | |||
There was a problem hiding this comment.
Expand a little bit on what ETL actually is
docs/etl.md
Outdated
|
|
||
| ## Configuration | ||
|
|
||
| Please follow the instructions below. |
There was a problem hiding this comment.
Please follow the instructions below to deploy the ETL service in a Bento stack,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.