Skip to content

Commit

Permalink
fix: stop spinner before starting to stream logs (#4846)
Browse files Browse the repository at this point in the history
Signed-off-by: Frost Ming <[email protected]>
  • Loading branch information
frostming authored Jul 10, 2024
1 parent a7515a0 commit a91ba14
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/bentoml/_internal/cloud/deployment.py
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ def wait_until_ready(
if spinner is not None:
stop_tail_event = Event()

def tail_image_builder_logs():
def tail_image_builder_logs() -> None:
cloud_rest_client = get_rest_api_client(self._context)
pod: KubePodSchema | None = None
while True:
Expand Down Expand Up @@ -539,6 +539,7 @@ def tail_image_builder_logs():
if is_first:
is_first = False
spinner.update("🚧 Image building...")
spinner.stop()
print(decoded_str, end="", flush=True)

tail_thread: Thread | None = None
Expand Down

0 comments on commit a91ba14

Please sign in to comment.