Skip to content

Commit c72a46f

Browse files
authored
Merge pull request #2 from berroar/upgrade-ds-to-v48
Upgrade ds to v48
2 parents 800af78 + 9b4f1d5 commit c72a46f

File tree

5 files changed

+28
-12
lines changed

5 files changed

+28
-12
lines changed

.design-system-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
46.1.4
1+
48.0.3

app/helpers/template_helpers.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,20 @@ def context(self) -> dict[str, Any]:
7373
}
7474

7575
@property
76-
def service_links_context(self) -> Optional[dict[str, list[dict]]]:
76+
def service_links_context(
77+
self,
78+
) -> Optional[dict[str, Union[dict[str, str], list[dict]]]]:
7779
if service_links := self._survey_config.get_service_links(
7880
sign_out_url=self._sign_out_url,
7981
is_authenticated=current_user.is_authenticated,
8082
):
81-
return {"itemsList": service_links}
83+
return {
84+
"toggleServicesButton": {
85+
"text": lazy_gettext("Menu"),
86+
"ariaLabel": "Toggle services menu",
87+
},
88+
"itemsList": service_links,
89+
}
8290

8391
return None
8492

app/translations/messages.pot

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ msgid ""
88
msgstr ""
99
"Project-Id-Version: PROJECT VERSION\n"
1010
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
11-
"POT-Creation-Date: 2022-03-29 09:47+0100\n"
11+
"POT-Creation-Date: 2022-04-12 12:38+0100\n"
1212
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
1313
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
1414
"Language-Team: LANGUAGE <[email protected]>\n"
@@ -203,11 +203,15 @@ msgstr[1] ""
203203
msgid "Not a valid choice."
204204
msgstr ""
205205

206-
#: app/helpers/template_helpers.py:110
206+
#: app/helpers/template_helpers.py:85
207+
msgid "Menu"
208+
msgstr ""
209+
210+
#: app/helpers/template_helpers.py:118
207211
msgid "The following links open in a new tab"
208212
msgstr ""
209213

210-
#: app/helpers/template_helpers.py:140
214+
#: app/helpers/template_helpers.py:148
211215
msgid ""
212216
"Make sure you <a href='{sign_out_url}'>leave this page</a> or close your "
213217
"browser if using a shared device"
@@ -380,7 +384,7 @@ msgstr ""
380384
msgid "Crown copyright and database rights 2020 OS 100019153."
381385
msgstr ""
382386

383-
#: app/survey_config/survey_config.py:43
387+
#: app/survey_config/survey_config.py:42
384388
msgid "Save and exit survey"
385389
msgstr ""
386390

@@ -711,11 +715,11 @@ msgstr ""
711715
msgid "View Submitted Response"
712716
msgstr ""
713717

714-
#: templates/calculatedsummary.html:14
718+
#: templates/calculatedsummary.html:13
715719
msgid "Please review your answers and confirm these are correct"
716720
msgstr ""
717721

718-
#: templates/calculatedsummary.html:25
722+
#: templates/calculatedsummary.html:24
719723
msgid "Yes, I confirm these are correct"
720724
msgstr ""
721725

@@ -1180,7 +1184,7 @@ msgstr ""
11801184
msgid "Continue survey"
11811185
msgstr ""
11821186

1183-
#: templates/layouts/_questionnaire.html:38
1187+
#: templates/layouts/_questionnaire.html:37
11841188
msgid "Choose another section and return to this later"
11851189
msgstr ""
11861190

tests/app/helpers/test_template_helpers.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,10 @@ def test_get_page_header_context_census_nisra(app: Flask):
160160
BusinessSurveyConfig(),
161161
True,
162162
{
163+
"toggleServicesButton": {
164+
"text": "Menu",
165+
"ariaLabel": "Toggle services menu",
166+
},
163167
"itemsList": [
164168
{
165169
"title": "My account",
@@ -171,7 +175,7 @@ def test_get_page_header_context_census_nisra(app: Flask):
171175
"url": "/sign-out",
172176
"id": "header-link-sign-out",
173177
},
174-
]
178+
],
175179
},
176180
),
177181
],

tests/functional/spec/features/calculated_summary.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import CurrencyTotalPlaybackPageSkippedFourth from "../../generated_pages/calcul
1212
import UnitTotalPlaybackPage from "../../generated_pages/calculated_summary/unit-total-playback.page.js";
1313
import PercentageTotalPlaybackPage from "../../generated_pages/calculated_summary/percentage-total-playback.page.js";
1414
import NumberTotalPlaybackPage from "../../generated_pages/calculated_summary/number-total-playback.page.js";
15-
import CalculatedSummaryTotalConfirmation from "../../generated_pages/calculated_summary/calculated-summary-total-confirmation.page";
15+
import CalculatedSummaryTotalConfirmation from "../../generated_pages/calculated_summary/calculated-summary-total-confirmation.page.js";
1616
import SubmitPage from "../../generated_pages/calculated_summary/submit.page";
1717
import ThankYouPage from "../../base_pages/thank-you.page.js";
1818

0 commit comments

Comments
 (0)