Schemas v5.39.0 #16
Open
Schemas v5.39.0 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add type hints to json.py * Update MyPy ini file to include the utilities module * Add type hints to decimal_places.py * Add type hints to metadata_parser.py * Add type hints to metadata_parser_v2.py * Add type hints to metadata_validators.py * Add type hints to request_session.py * Add type hints to schema.py * Add type hints to supplementary_data_parser.py * Format python code * Fix variable name issue * Tidy up pylint comments * Add more type hint definitions * test new changes to ensure the deserialize method uses default format (iso8601) unless a format is specified * Tidy up type hints and add missing hints for empty collection * Refactor code to improve type hints * Refactor/improve type hints and install new dev package * Refactor more type hints * Update type ignore message * Fix type hinting * Correct type hint for parameter * Remove types-simplejson package * Revert pipfiles * Revert pipfile.lock
* Update Node to version v20.9.0 * Drop yarn commands across files and test GHA * Remove yarn from run_tests script * Update README and package-lock.json and remove .yarnrc * Fix package-lock.json in order to fix broken test * Update pull_request.yaml to cache when setting up node * Fix missing code in pull_request.yaml * Remove unnecessary caching code from pull_request.yaml * Update README and update node to the latest version * Update package-lock.json
* Copy QuestionnaireStoreUpdater into BaseQuestionnaireStoreUpdater * Split methods between store updaters * Capture dependencies when modifying supplementary data * Refactor to avoid is_repeating_answer flag for lists * Combine store updaters for ease of review * Move supplementary data methods to the base QSU * Use supplementary data property for simplification * Move and use location helpers * Refactor remove dependent blocks and capture sections * Use section key for capture dependent section
* List collector content progress tests
* Dockerise mock CIR * Functionally test CIR
* Add changes to files * Addd updated translations * Fix metadata after schema theme change * Fix confirmation email error panel test * Translations and remove template census thank you * Remove census survey config and themes in files * Remove census survey config and themes in test files * Remove tests and format tests * Add ru_name to relevant schemas and update messages.pot, point runner to use a different validator branch * Fix tests and schema * Fix metadata ru_name issue in schema * Fix census mention in ThankYou class and update translations * Update translations babel version * Change template name and references * Remove comments * Remove more census related schemas/tests * Update messages.pot * Fix form in context * Remove test that does the same as another and revert tag in run_validator.sh * Remove and fix broken tests * Remove further census survey configs and update schemas/tests/docs * Fix broken test and format json/python files * Revert changes to a historical document * Revert deleted env variable * Revert changes made * Revert broken test to original --------- Co-authored-by: petechd <[email protected]> Co-authored-by: petechd <[email protected]>
* Handle Grand Calculated Summary Dependencies * Tests for GCS Dependencies * Use validator branch * Use correct validator branch * Make names consistent * Update functional test for dependencies * Fix unit test for renamed answer id * Use more generic type for source types * Simplify When rule dependencies (#1271) * Simplify when rule dependencies * Restore validator branch --------- Co-authored-by: Rhys Berrow <[email protected]> Co-authored-by: Mebin Abraham <[email protected]>
--------- Co-authored-by: Mebin Abraham <[email protected]> Co-authored-by: Mebin Abraham <[email protected]>
--------- Co-authored-by: Mebin Abraham <[email protected]>
…nt-Issues ECI-1618 Resolve Ruff Perflint Issues
* point to validator branch * update AJV_HOST enviroment variable to AJV_VALIDATOR_HOST * revert validator tag
Signed-off-by: Yuyutsu Rai <[email protected]>
ECI 1603 Resolve Ruff lint error messages issues
* Remove Push to Docker Hub Step in Github Actions * remove docker hub tag path * Remove Folded Block Scalar in Build step: * exlcude hub and spoke and supplementary datag * remove hub and spoke and supplementary data suites from GA matrix * remove specs from exclude config in WDIO * Remove DockerHub Build Step
…pdate CodeQL Configuration (#1659) * Assign worfklows permissions and pin dependices to a commit hash * remove with matrixes in aalysis perform Signed-off-by: Yuyutsu Rai <[email protected]> * update codeql with standard advanced configuration * remove manual mode| * revert removal of maunal matrix mode * remove typescript from the language matrix * remov e commenst and change build mode toauto build * revert back to none build mode * remove manual mode if statement * give blank space * update Anlayse in codeyaml * remove with paramter * update reomve buildmode paramter * revert title and lanauge formatting * pin commmits in codeql analysis yml * specifiy ubuntu version * pin actions to commit hash Signed-off-by: Yuyutsu Rai <[email protected]> * Add Build mode option to matrix * update pathing to language in codeql analysis perform job Signed-off-by: Yuyutsu Rai <[email protected]> * update name and formatting to be consistent * add permission to job in pull request yml --------- Signed-off-by: Yuyutsu Rai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Latest schemas: https://github.com/ONSdigital/eq-questionnaire-schemas/releases/tag/v5.39.0
How to review
Ensure the correct version is loaded when running make build