Fix user agent hint platform for macOS #810
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the `_getPlatform` function to correctly return the user agent hint for macOS devices in stealth mode. The function now returns 'macOS' instead of 'Mac OS X' when the `extended` parameter is set to `true`. Also updated the test case to reflect the change in the `sec-ch-ua-platform` header for macOS devices.
github-actions
bot
added
plugin: puppeteer-extra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue with the
_getPlatformfunction in the user-agent-override evasion where the user agent hint platform for macOS devices was incorrectly returned as 'Mac OS X' instead of 'macOS'.In the real world, the
sec-ch-ua-platformheader for macOS devices is set to 'macOS', as documented in the official MDN Web Docs (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Sec-CH-UA-Platform).The function has been updated to correctly return 'macOS' when the
extendedparameter is set totrue. I have also updated the corresponding test case to reflect the change in thesec-ch-ua-platformheader for macOS devices.