Skip to content

Use opts.userDataDir if launchPersistentContext calls with empty args #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use opts.userDataDir if launchPersistentContext calls with empty args #884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/playwright-extra/src/extra.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ interface AugmentedLauncherAPIs
extends Pick<
PlaywrightBrowserLauncher,
'launch' | 'launchPersistentContext' | 'connect' | 'connectOverCDP'
> {}
> { }

/**
* Modular plugin framework to teach `playwright` new tricks.
Expand Down Expand Up @@ -119,6 +119,14 @@ export class PlaywrightExtraClass implements AugmentedLauncherAPIs {
options =
(await this.plugins.dispatchBlocking('beforeLaunch', options)) || options

if ('userDataDir' in options && !userDataDir) {
userDataDir = (options as any).userDataDir
debug(
"A plugin defined userDataDir during .launchPersistentContext", userDataDir
)
delete (options as any).userDataDir
}

const context = await this.launcher['launchPersistentContext'](
userDataDir,
options
Expand Down