Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #4 add transform-group option to use single wrapper element #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mojavelinux
Copy link

  • using single wrapper to scale slides if option is transform-group
  • fix tests
  • add tests for transform-group option

@mojavelinux
Copy link
Author

As a side note, tests don't work on Firefox for some reason. However, I did manually testing in Firefox and it works great.

… element

- using single wrapper to scale slides if option is transform-group
- fix tests
- add tests for transform-group option
- document transform-group option in README
@mojavelinux
Copy link
Author

I realized that when transform-group is specified, it still uses zoom in Chrome. This differs from the transform option, which uses transform for all browsers. So we have an extra degree of configuration here. Should we switch to an options map so that we can have a separate flag for whether to wrap each slide or the group of slides?

zoom with transform (on group) fallback

{ applyTo: 'group' }

transform (on group)

{ method: 'transform', applyTo: 'group' }

The default would be:

{ applyTo: 'slide' }

@mojavelinux
Copy link
Author

When applyTo is "group", I'd also move the zoom to this wrapper element so that the change is consistent.

@mojavelinux
Copy link
Author

Or maybe we can simplify the option name to "on":

{ method: 'transform', on: 'group' }

Is there a value you prefer to describe the group of slides instead of "group"?

@mojavelinux
Copy link
Author

Another possibility is to use a fallback chain, like:

scale('zoom|transform group')

vs

scale('zoom|transform slide')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant