feat(admin,api): 3769 - Affectation réelle CLE Métropole #4671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achorein
changed the title
achorein
force-pushed
the
feat/affectation-cle-simulation
branch
from
2b09dd1 to
19290ef
Compare
achorein
force-pushed
the
feat/affectation-cle-valider
branch
from
cbdf826 to
1fa591d
Compare
achorein
force-pushed
the
feat/affectation-cle-simulation
branch
from
19290ef to
25fc858
Compare
achorein
force-pushed
the
feat/affectation-cle-valider
branch
from
1fa591d to
38c1836
Compare
Johannbr
approved these changes
Jan 24, 2025
| }, | ||
| onError: (error: any) => { | ||
| capture(error); | ||
| toastr.error("Une erreur est survenue lors de l'ajout du traitement", translate(JSON.parse(error.message).message), { timeOut: 5000 }); |
There was a problem hiding this comment.
Dans apiv2.ts, on affiche un toast pour les erreurs non prévues, tu peux avoir plusieurs toast d'erreur si c'est autre chose qu'une 401, 422 ou ERR_NETWORK :
if (error instanceof FunctionalException) {
toastr.error("Une erreur est survenue lors de l'ajout du traitement", translate(JSON.parse(error.message).message), { timeOut: 5000 });
}
| const validationCleResult = await this.validerAffectationCle.execute({ | ||
| ...validationCleTask.metadata!.parameters!, | ||
| dateAffectation: validationCleTask.createdAt, | ||
| }); |
There was a problem hiding this comment.
Pour éviter de faire grossir ce switch les case pourraient être ressorti dans des méthodes private : doAffectationCleSimulationValider.
Qu'en penses tu ?
| analytics.jeunesAffected += 1; | ||
| } | ||
|
|
||
| this.cls.set("user", { firstName: `Affectation ${session.nom}` }); |
There was a problem hiding this comment.
Le cls est déjà setté dans AdminTaskConsumer
| TaskName.AFFECTATION_CLE_SIMULATION_VALIDER, | ||
| ); | ||
|
|
||
| console.log("status", status, "lastCompletedAt", lastCompletedAt); |
| }), | ||
| ); | ||
|
|
||
| console.log(result); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todo
Ticket / Issue
https://www.notion.so/jeveuxaider/Affectation-r-elle-CLE-M-tropole-hors-Corse-15872a322d5080e7975ee3324fe98354?pvs=23
Testing instructions
https://snufeataffectationclsskyr8ol-admin.functions.fnc.fr-par.scw.cloud