Skip to content

add build flags to bao-console #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025
Merged

add build flags to bao-console #657

merged 1 commit into from
Jun 9, 2025

Conversation

bunnie
Copy link
Member

@bunnie bunnie commented Jun 9, 2025

This time with rebasing.

two flags are added:

with-pddb - puts the PDDB commands into the console
battery-readout - turns on the periodic battery readout

I bet this has conflicts with your branch @samchin. Please let me know if some changes on my side would reduce merge conflicts.

two flags are added:

with-pddb - puts the PDDB commands into the console
battery-readout - turns on the periodic battery readout
@bunnie bunnie requested a review from samchin June 9, 2025 09:21
Copy link
Contributor

@samchin samchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the -- feature "battery-readout" which worked as expected.

I compiled the -- feature "with-pddb" which also worked.

@samchin
Copy link
Contributor

samchin commented Jun 9, 2025

Also if you change bao.sh to have cargo xtask baosec --feature "mpw" --loader-feature "cramium-mpw" "$@", you can call: ./baosec.sh --feature "battery-readout" from the command line

@bunnie bunnie marked this pull request as ready for review June 9, 2025 10:46
@bunnie bunnie merged commit 5108239 into main Jun 9, 2025
2 checks passed
@bunnie bunnie deleted the console-flags-part-deux branch June 9, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants