Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues in IE #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issues in IE #50

wants to merge 1 commit into from

Conversation

backflip
Copy link

  • Rewriting for … of loops. An alternative would be integrating babel-polyfill (or suggesting the user to load it), but it would increase the payload by 30kb. Selectively polyfilling for Array.from wasn't really successful (still choking on Out-of-date browser support #49 (comment))
  • Using Element.parentNode as a fallback for Element.parentElement, which apparently doesn't work for TextNode in IE.
  • Using a less elegant approach to make NodeList iterable ([].slice.call(document.querySelector())over [...document.querySelector()])
  • Mentioning the need for a Element.classList polyfill in IE9
  • Dropping IE7 and 8 (I didn't get it to work there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant