-
Notifications
You must be signed in to change notification settings - Fork 86
Update Design book architecture page #264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| - how does the Bevy editor communicate with the Bevy game to enable effective scene editing with user-defined types? | ||
| - how should undo-redo be handled? | ||
| - How should undo-redo be handled? | ||
| - How should the `editor_core` api be designed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This question is unclear.
alice-i-cecile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like these changes: a lot of useful content has been lost, and there's a number of contentious changes. I don't have the time to review / revise this further right now, sorry Rin.
Im not sure what content has been lost? Some stuff was just reworded and moved elsewhere in the page (line 24 into 20) and some of it is questions that the added portions answers, (line 32 answered by 76). I only see a few lines that went from explicit to implicit within the doc (like lines 20-23 got condensed down into line 85). Overall the arch is the same as what was discussed in the discord, just better worded with more clarity to reasoning. |
|
I would prefer to keep the structure unaltered and the changes minimal. It's quite challenging to review the diff currently. |
Update the architecture to reflect the current general consensus for the MVP editor. Several of the open questions have been answered at least in regards to the MVP.
First of many updates to come to the book.