Skip to content

Conversation

@Atlas16A
Copy link
Contributor

Update the architecture to reflect the current general consensus for the MVP editor. Several of the open questions have been answered at least in regards to the MVP.
First of many updates to come to the book.

- how does the Bevy editor communicate with the Bevy game to enable effective scene editing with user-defined types?
- how should undo-redo be handled?
- How should undo-redo be handled?
- How should the `editor_core` api be designed?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This question is unclear.

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like these changes: a lot of useful content has been lost, and there's a number of contentious changes. I don't have the time to review / revise this further right now, sorry Rin.

@Atlas16A
Copy link
Contributor Author

Atlas16A commented Jan 26, 2026

I don't like these changes: a lot of useful content has been lost, and there's a number of contentious changes. I don't have the time to review / revise this further right now, sorry Rin.

Im not sure what content has been lost? Some stuff was just reworded and moved elsewhere in the page (line 24 into 20) and some of it is questions that the added portions answers, (line 32 answered by 76). I only see a few lines that went from explicit to implicit within the doc (like lines 20-23 got condensed down into line 85). Overall the arch is the same as what was discussed in the discord, just better worded with more clarity to reasoning.
Do you want me to bring back the stuff that become implicit? Or is it the structure of the changes? I felt keeping the Question format didn't make much sense since it was moving towards a general consensus?

@alice-i-cecile
Copy link
Member

I would prefer to keep the structure unaltered and the changes minimal. It's quite challenging to review the diff currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants