-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map metadata integration #278
Map metadata integration #278
Conversation
bcdrme
commented
Nov 6, 2024
•
edited
Loading
edited
- Replaced local map parsing with metadata service
- Fix AIs modal
- Game options PoC, options modal is fixed
- Better preload step
- Update deps (electron 33.2.0)
- Fix scenarios with loadout
- win32 build works with squirrel
- Fix modoptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced local map parsing with metadata service
that entirely dropped map parsing, so looking at the code it looks like it's not possible to use local maps that aren't part of official distribution?
Please, please, please make smaller PRs that change less things, I will be asking to split PRs if any like this come in the future, it's really brutal to review.
Yup, it's dropped for now.
I mean, I'm kinda torn on this one. This project is in a very early stage, ofc there's gonna be tons of changes if we want to move fast. |
Merging it as is, will open two other PRs for
|