Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map metadata integration #278

Merged
merged 25 commits into from
Nov 10, 2024

Conversation

bcdrme
Copy link
Contributor

@bcdrme bcdrme commented Nov 6, 2024

  • Replaced local map parsing with metadata service
  • Fix AIs modal
  • Game options PoC, options modal is fixed
  • Better preload step
  • Update deps (electron 33.2.0)
  • Fix scenarios with loadout
  • win32 build works with squirrel
  • Fix modoptions

@bcdrme bcdrme requested a review from p2004a November 6, 2024 16:50
Copy link
Contributor

@p2004a p2004a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced local map parsing with metadata service

that entirely dropped map parsing, so looking at the code it looks like it's not possible to use local maps that aren't part of official distribution?


Please, please, please make smaller PRs that change less things, I will be asking to split PRs if any like this come in the future, it's really brutal to review.

src/main/content/maps/map-metadata.ts Outdated Show resolved Hide resolved
src/main/content/maps/map-metadata.ts Outdated Show resolved Hide resolved
src/main/content/maps/map-metadata.ts Outdated Show resolved Hide resolved
src/main/content/maps/map-metadata.ts Show resolved Hide resolved
src/renderer/store/maps.store.ts Show resolved Hide resolved
src/renderer/components/battle/GameModeComponent.vue Outdated Show resolved Hide resolved
src/renderer/components/misc/Preloader.vue Outdated Show resolved Hide resolved
src/renderer/store/db.ts Show resolved Hide resolved
vendor/map-parser/ultrasimple-map-parser.ts Outdated Show resolved Hide resolved
src/renderer/store/battle.store.ts Outdated Show resolved Hide resolved
@bcdrme
Copy link
Contributor Author

bcdrme commented Nov 9, 2024

Replaced local map parsing with metadata service

that entirely dropped map parsing, so looking at the code it looks like it's not possible to use local maps that aren't part of official distribution?

Yup, it's dropped for now.
Now that being said, how can someone working on a new map run it using the new lobby ... I didn't think this through

Please, please, please make smaller PRs that change less things, I will be asking to split PRs if any like this come in the future, it's really brutal to review.

I mean, I'm kinda torn on this one. This project is in a very early stage, ofc there's gonna be tons of changes if we want to move fast.
On the other hand I completely understand your sentiment.
I'd like to keep the momentum going. Available on Discord to discuss this.

@bcdrme
Copy link
Contributor Author

bcdrme commented Nov 10, 2024

Merging it as is, will open two other PRs for

  • fixing some issues with replay parsing
  • adding back local map-parsing with a UI element to trigger the folder scan

@bcdrme bcdrme merged commit 95a6fee into beyond-all-reason:master Nov 10, 2024
1 check passed
@bcdrme bcdrme deleted the map-metadata-integration branch November 10, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants