Add #[SuppressQueryDetection] attribute to suppress N+1 detection per method #115
Closed
dingyaguang117 wants to merge 0 commit intobeyondcode:masterfrom
Closed
Add #[SuppressQueryDetection] attribute to suppress N+1 detection per method #115dingyaguang117 wants to merge 0 commit intobeyondcode:masterfrom
dingyaguang117 wants to merge 0 commit intobeyondcode:masterfrom
Conversation
01a2b76 to
8b0ac19
Compare
8b0ac19 to
0f2b166
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#[SuppressQueryDetection]attribute that can be placed on any method to suppress N+1 query detection for all queries triggered within it (including nested calls)Motivation
The existing except config requires whitelisting by model + relation pair, which is too coarse-grained. In practice, developers often need to suppress detection for a specific method (e.g. an admin controller action, a background job, or a legacy endpoint) rather than globally whitelisting a
relation.
This attribute-based approach gives fine-grained, code-level control — just annotate the method: