Clarify Timeouts and make HTTPClient timeout configureable #198
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
TimeoutinRequestConfigurationtoConnectTimeout, as this value only applies to establishing a connection—not the full HTTP request/response cycle.Source
Renamed
TimeouttoBlockTimeout, since it refers to the timeout for a single block.After further contemplation, we should probably call it
ChunkTimeout.Added
HttpClientTimeoutto control the timeout for an entire HTTP request.Not sure how useful this is, as it overlaps with
BlockTimeout.I’d also be fine setting
HttpClient.TimeouttoBlockTimeoutinstead and removing the HttpClientTimeout option.But we should make this configurable in some way (see below).
Feedback on this is welcome.
I noticed this issue while debugging downloads that exceeded 100 seconds (the default value of
HttpClient.Timeout).Regardless of how I set the two existing timeouts, the request always stopped after 100 seconds.
We could consider writing a test for this, but I’m not very experienced with writing tests.