VAECache needs to shuffle bucket contents before splitting across GPUs #1701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 6, 2025 09:47
…o GPUs, so that we do not end up with sequence distribution fault
bghira
commented
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when some cache is preserved across restarts, work units are distributed unevenly across GPUs, as, one or more GPUs may contain solely corrupted samples.
the reduction in bucket contents went from 79k to 4 samples, but when shuffling before distribution, we'd get better results and each worker receives 19k remaining samples to process.
removed
do_shuffleparameter for reduce_buckets because it's been split by this point and shuffling does nothing.