-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding route server support #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! If no further comments, I'll merge it in on Wednesday.
* location (Peering Location, as defined above) | ||
* status (Session Status, as defined above) | ||
* session_id (of individual session and generated by the server) | ||
|
||
As not all elements are reflected in the {{autopeer}} OpenAPI definition to date, we define the missing fields here to be reflected in {{autopeer}} in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
As an aside, we should probably update the OpenAPI spec and move it in to the IETF draft as well (also brought up in #30), but that's outside the scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an aside, we should probably update the OpenAPI spec and move it in to the IETF draft as well (also brought up in #30), but that's outside the scope of this PR.
I think that’s a very reasonable approach. RFCs should be self-contained. I’m happy to help with editing tasks like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We'd welcome the help.
IANA Considerations {#iana} | ||
=================== | ||
|
||
This document has no IANA actions. | ||
|
||
--- back | ||
|
||
|
||
Acknowledgments {#acknowledgments} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to add yourself as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done.
Fine for me, thank you. |
Hi all,
after some discussion with Jenny and Arturo, I have prepared this PR to add necessary fields for route server support at IXPs to the draft. I am happy to work on any feedback.
I was a bit unsure where to add the explanation of new fields, that are not yet reflected in the autopeer OpenAPI definition. For the time being I placed them in the BGP Session section, but they might fit better somewhere else. To be discussed.
Regards,
Matthias