Skip to content

Conversation

@effigies
Copy link
Collaborator

@effigies effigies commented Nov 15, 2024

This PR is aimed at speeding up the build time, which currently clocks in at 2.5m. Let's see if we can't shave off at least 30s.

@effigies
Copy link
Collaborator Author

effigies commented Nov 15, 2024

Pre-build Build Total
Before 88s 60s 148s
After 26s 72s 98s

So we can cut off about a minute (~65%) of pre-build time. Without investigating the range of build times, we're probably going from 2-3 minutes to 1-2 minutes, so a 30-50% saving.

Will leave it to other maintainers to decide if the complexity of the RTD config isn't justified. It's always possible to go back if this is found difficult to maintain, though.

@Remi-Gau
Copy link
Collaborator

I would be OK with this

out of curiosity, the virtual is not kept across build is it?

@effigies
Copy link
Collaborator Author

Nope.

@effigies effigies added exclude-from-changelog This item will not feature in the automatically generated changelog infrastructure labels Nov 18, 2024
@effigies effigies merged commit 85ee481 into bids-standard:master Dec 12, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

exclude-from-changelog This item will not feature in the automatically generated changelog infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants